-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyNWB 3.0 support #557
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #557 +/- ##
==========================================
+ Coverage 82.73% 86.73% +3.99%
==========================================
Files 47 47
Lines 1512 1515 +3
==========================================
+ Hits 1251 1314 +63
+ Misses 261 201 -60
|
Do you have any idea why the streaming tests are taking more than 1h 45m? |
I'm not sure, I just noticed that. I can cancel the run for now and try to debug locally? |
Sounds good. Also, some time ago we had unofficially decided that NWB Zarr files should have the suffix ".nwb.zarr". I think we should keep that. NeurodataWithoutBorders/pynwb#1976 (comment) . NWB HDF5 files should still have suffix ".nwb" though. It can have the "hdf5" part before then to be explicit in these tests if we want. |
Ah right, thanks for catching. I was modifying the tests to address the new NWBHDF5IO warning to use the |
Motivation
Address deprecations and validation changes in the upcoming PyNWB 3.0 release.
Note: I left some remaining TODO items that can be updated after the official release when 3.0 becomes the new minimum for NWBInspector.
To test: