Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this check is missing #462

Merged
merged 3 commits into from
May 21, 2024
Merged

this check is missing #462

merged 3 commits into from
May 21, 2024

Conversation

bendichter
Copy link
Contributor

I also don't know how we would check this automatically

@CodyCBakerPhD
Copy link
Contributor

The name of the check is now check_image_series_data_size in the image_series submodule: https://github.com/NeurodataWithoutBorders/nwbinspector/blob/dev/src/nwbinspector/checks/image_series.py#L55C5-L55C33

It allows the data to be written internally (with gzip or others) up to a threshold of 20GB - only applies to HDF5 at the moment

This best practice would also change when using the Zarr backend (I think recommendation would to use Jeremy's MP4 codec)

@bendichter
Copy link
Contributor Author

Let's look at updating this check to make sure it applies specifically to behavioral videos

  • It should also apply to OnePhotonSeries
  • The error message should specifically indicate behavioral videos.

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) May 21, 2024 20:39
@CodyCBakerPhD CodyCBakerPhD merged commit 6110d44 into dev May 21, 2024
15 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the rmv_missing_check branch May 21, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants