Dynamic table unique ids #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
CodyCBakerPhD
added
the
category: new check
|
LGTM - did you check this against the NeuroNexus file? |
yup., it catches it |
CodyCBakerPhD
approved these changes
Nov 30, 2022
Great, can you write or update a best practices section in the docs for it as well? In that section it can be mentioned that the easiest solution is often to try updating the PyNWB version. For custom DynamicTables obviously the user has full control over that kind of stuff, but this violation came from something that old PyNWB versions generated automatically through convenience functions like the first call to |
CodyCBakerPhD
approved these changes
Nov 30, 2022
|
Codecov v3 has had problems uploading on occasion - feel free to ignore and merge or otherwise retrigger it and hope for the best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
What was the reasoning behind this change? Please explain the changes briefly.