Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_data_shape for unbounded dataset #315

Merged
merged 3 commits into from
Nov 30, 2022
Merged

fix get_data_shape for unbounded dataset #315

merged 3 commits into from
Nov 30, 2022

Conversation

bendichter
Copy link
Contributor

  • create a custom get_data_shape that does not return maxshape
  • write test that has an unbounded dataset

@codecov-commenter
Copy link

Codecov Report

Merging #315 (4f65e35) into dev (d324736) will decrease coverage by 0.00%.
The diff coverage is 95.00%.

❗ Current head 4f65e35 differs from pull request most recent head 3c81420. Consider uploading reports for the commit 3c81420 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #315      +/-   ##
==========================================
- Coverage   93.91%   93.90%   -0.01%     
==========================================
  Files          20       20              
  Lines        1068     1083      +15     
==========================================
+ Hits         1003     1017      +14     
- Misses         65       66       +1     
Flag Coverage Δ
unittests 93.90% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/nwbinspector/checks/tables.py 96.66% <ø> (-0.04%) ⬇️
src/nwbinspector/utils.py 87.27% <94.11%> (+1.25%) ⬆️
src/nwbinspector/checks/ecephys.py 100.00% <100.00%> (ø)
src/nwbinspector/checks/ophys.py 100.00% <100.00%> (ø)
src/nwbinspector/checks/time_series.py 95.12% <100.00%> (-0.12%) ⬇️

@CodyCBakerPhD
Copy link
Contributor

Re-triggering tests after pre-commit bot, something strange happened

@CodyCBakerPhD CodyCBakerPhD added the category: bug errors in the code or code behavior label Nov 30, 2022
@CodyCBakerPhD CodyCBakerPhD merged commit 733e711 into dev Nov 30, 2022
@CodyCBakerPhD CodyCBakerPhD deleted the fix_data_shape branch November 30, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants