-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use data files for various tests #288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyCBakerPhD
changed the title
Use existing data files
Use data files for various tests
Oct 9, 2022
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…awithoutborders/nwbinspector into use_existing_data_files
for more information, see https://pre-commit.ci
…awithoutborders/nwbinspector into use_existing_data_files
for more information, see https://pre-commit.ci
…awithoutborders/nwbinspector into use_existing_data_files
Codecov Report
@@ Coverage Diff @@
## dev #288 +/- ##
==========================================
+ Coverage 93.95% 93.97% +0.01%
==========================================
Files 20 20
Lines 1026 1045 +19
==========================================
+ Hits 964 982 +18
- Misses 62 63 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Swapping to using specific soon-to-be-outdated versions of PyNWB to generate NWB files that trigger certain Best Practices since they can no longer be made in-memory.
A couple other things along the way...
nwbinspector.testing
submodule, also enforcing structure of/src/
outer level