Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix for reading files written using extensions #262

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

CodyCBakerPhD
Copy link
Contributor

Small but important bug fix for the identifier check added in #157 - forgot to include load_namespaces=True in the NWBHDF5IO pre-call that applies before deploying the full inspection on each file to collect all the folder-level identifiers.

@CodyCBakerPhD CodyCBakerPhD added category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users labels Sep 15, 2022
@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 15, 2022
@CodyCBakerPhD CodyCBakerPhD merged commit aa76674 into dev Sep 15, 2022
@CodyCBakerPhD CodyCBakerPhD deleted the fix_load_namespaces_identifier_check branch September 15, 2022 17:58
@CodyCBakerPhD
Copy link
Contributor Author

For provenance, bug discovered and communicated by @h-mayorquin on Slack. Also related to a possible mis-documentation/communication of the --modules flag, but that's a separate issue we'll try to improve as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants