Add environmental control over network-dependent tests #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyCBakerPhD
added
category: enhancement
for more information, see https://pre-commit.ci
2 tasks
oruebel
reviewed
Sep 15, 2022
oruebel
reviewed
Sep 15, 2022
oruebel
reviewed
Sep 15, 2022
oruebel
reviewed
Sep 15, 2022
oruebel
requested changes
Sep 15, 2022
There was a problem hiding this comment.
@CodyCBakerPhD the approach in general looks fine. The comments I added are mainly to help clean the code up a bit (e.g, to avoid code duplication)
Codecov Report
@@ Coverage Diff @@
## dev #261 +/- ##
==========================================
- Coverage 94.45% 90.60% -3.85%
==========================================
Files 19 20 +1
Lines 992 1022 +30
==========================================
- Hits 937 926 -11
- Misses 55 96 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
oruebel
reviewed
Sep 15, 2022
oruebel
reviewed
Sep 15, 2022
CodyCBakerPhD
deleted the
make_connectivity_tests_explicitly_skippable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #260
@TheChymera, does this meet your request?