Update dandi.inspector_config.yaml

nwbinspector/internal_configs/dandi.inspector_config.yaml

@@ -1,8 +1,8 @@
 CRITICAL:  # All the fields under CRITICAL will be required for dandi validate to pass
   - check_subject_exists
   - check_subject_id_exists
+  - check_subject_sex
+  - check_subject_species
+  - check_subject_age
 BEST_PRACTICE_VIOLATION:
-  - check_subject_sex # these are planned to be elevated to CRITICAL when required for DANDI validate
-  - check_subject_species # these are planned to be elevated to CRITICAL when required for DANDI validate
-  - check_subject_age # these are planned to be elevated to CRITICAL when required for DANDI validate
   - check_data_orientation  # not 100% accurate, so need to deelevate from CRITICAL to skip it in dandi validate

tests/test_check_configuration.py

@@ -70,11 +70,14 @@ def test_load_config(self):
         self.assertDictEqual(
             d1=config,
             d2=dict(
-                CRITICAL=["check_subject_exists", "check_subject_id_exists"],
-                BEST_PRACTICE_VIOLATION=[
+                CRITICAL=[
+                    "check_subject_exists",
+                    "check_subject_id_exists",
                     "check_subject_sex",
                     "check_subject_species",
                     "check_subject_age",
+                ],
+                BEST_PRACTICE_VIOLATION=[
                     "check_data_orientation",
                 ],
             ),