Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing suite for PyNWB v2.1.0 #219

Closed
wants to merge 6 commits into from

Conversation

CodyCBakerPhD
Copy link
Contributor

Discovered from #218, fixed here. Raised also in NeurodataWithoutBorders/pynwb#1497

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jul 7, 2022
@bendichter
Copy link
Contributor

If you want to remove x, y, and z, you'll need to set the pynwb requirement to >= 2.1.0

@CodyCBakerPhD
Copy link
Contributor Author

If you want to remove x, y, and z, you'll need to set the pynwb requirement to >= 2.1.0

Note that the removal is purely for testing purposes, and testing always performs using latest requirements without having to enforce the minimal install on others. That said it's also not intended behavior so I expect them to fix it quite soon anyway. No change to core behavior is expected for our checks w.r.t <= 2.1.0

@bendichter
Copy link
Contributor

bendichter commented Jul 8, 2022

testing always performs using latest requirements without having to enforce the minimal install on others

what do you mean?

If I run pytest on my local machine, it won't be guaranteed to run the latest version of every package

@CodyCBakerPhD CodyCBakerPhD marked this pull request as draft July 8, 2022 16:26
@CodyCBakerPhD
Copy link
Contributor Author

If I run pytest on my local machine, it won't be guaranteed to run the latest version of every package

I was narrowly thinking about only the CI workflows that use fresh installs of all the most recent dependencies unless an upper bound is applied.

I can see how that would be limiting for local testing, though, so swapped with a pytest.skipIf condition that will be removed once the upstream issue is fixed.

@CodyCBakerPhD CodyCBakerPhD deleted the fix_test_for_2_1_0 branch July 11, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants