-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make Clustering
and FeatureExtraction
inherit from TimeSeries
#112
Comments
@bendichter generally I think if what used to be an "Interface" in NWB 1.x looks and feels like a TimeSeries then we should have a look at whether it should become one. I need to have a look at the implications of this for these types to make sure we don't add any new requirements to these types that will break things. Let me have a look and get back to you. |
Great, thanks. Making these objects |
@bendichter I agree with 2) and more broadly speaking, I think the advantage lies in the ability to unify APIs for these objects. Re 1), I think that would be more of an unintended side-effect. Clustering and FeatureExtraction are usually not raw acquistions so putting them there does not seem right. |
Yeah, 1 is more for the LFP object
…On Tue, Jan 30, 2018 at 4:44 PM, Oliver Ruebel ***@***.***> wrote:
@bendichter <https://github.com/bendichter> I agree with 2) and more
broadly speaking, I think the advantage lies in the ability to unify APIs
for these objects. Re 1), I think that would be more of an unintended
side-effect. Clustering and FeatureExtraction are usually not raw
acquistions so putting them there does not seem right.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#112 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAziEtBHZIZhi7ZydAs89NkHR-zukiD3ks5tP7d7gaJpZM4RsJbY>
.
--
----------
Ben Dichter, PhD
Data Science Consultant
|
but they can be, e.g. http://ieeexplore.ieee.org/document/7933210/ |
I'd like to link
Epoch
s withClustering
objects, but I can't because they are notTimeSeries
objects. They have the necessary components-- timestamps and data (where the data is the cluster number id) so it should be doable to make theTimeSeries
objects without changing thepynwb
API.The text was updated successfully, but these errors were encountered: