Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify backend dependencies #906

Merged
merged 14 commits into from
Aug 5, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Collaborator

@CodyCBakerPhD CodyCBakerPhD commented Aug 4, 2024

Build tests just started failing due to a new hidden library in matplotlib, which we shouldn't even need as far as I know to run GUIDE (I tried removing locally and ran through a bunch of pipelines, including tutorial generation, and everything worked fine)

I think spikeinterface[qualitymetrics] in neuroconv[testing] (a part of neuroconv[full]) might be the source of that, so testing if this simplifies things

In the same spirit, there is no reason to bundle pytest or pytest-cov with our actual official build releases, so I'm suggesting only installing it in the CI where it is needed to run tests

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 4, 2024
@CodyCBakerPhD
Copy link
Collaborator Author

Well I still have no idea where matplotlib is being installed from out of that, but I still think trimming the testing requirements out of package setup for GUIDE is in our best interest for everything outside of CI

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 5, 2024 01:53
@CodyCBakerPhD CodyCBakerPhD requested a review from rly August 5, 2024 01:53
@CodyCBakerPhD CodyCBakerPhD merged commit 6049949 into main Aug 5, 2024
11 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the remove_non_testing_installations branch August 5, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants