Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update switcher for 1.0.2 #886

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Update switcher for 1.0.2 #886

merged 2 commits into from
Jul 1, 2024

Conversation

rly
Copy link
Collaborator

@rly rly commented Jun 27, 2024

Before release of 1.0.2

@CodyCBakerPhD
Copy link
Collaborator

Exactly my suspicion as well

Need to change https://github.com/NeurodataWithoutBorders/nwb-guide/pull/886/files#diff-4e8e667a6b53889132b09d57fb7cdb38aa0d577fd5a7406592b2d6fdfaf850eeR17 to false since the switcher can only have one preferred at a time (source)

However, we would only swap the preference immediately before release, WDYT?

@rly
Copy link
Collaborator Author

rly commented Jun 28, 2024

Yes, we should swap immediately before release. I was going to propose a release ahead of the user test which was cancelled yesterday. The next one is Tuesday. What do you think about merging this and making a release today / this weekend?

@rly rly requested a review from CodyCBakerPhD June 28, 2024 20:47
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge July 1, 2024 11:40
@CodyCBakerPhD CodyCBakerPhD merged commit 85b21c6 into main Jul 1, 2024
21 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the update_switcher branch July 1, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants