Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List individual errors when multiple are detected #872

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

rly
Copy link
Collaborator

@rly rly commented Jun 22, 2024

Fix #871.
The error used to say:

[sub-sub1/ses-ses1]: 2 JSON Schema errors detected.

Now it says:

[sub-sub1/ses-ses1]: 2 errors detected: Form requires property "sex". Form requires property "species".

It would be nicer to say Subject form requires X, but I believe the "Form requires" part comes from JSON schema so we would have to find and replace based on the source. That's more involved and I suggest it as a future enhancement.

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge June 22, 2024 14:45
@CodyCBakerPhD CodyCBakerPhD merged commit a2b6080 into main Jun 22, 2024
22 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the improve_error_msg branch June 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When multiple validation errors occur in a form, the error popup is cryptic
2 participants