Fix Validation with Timezone Awareness #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
CodyCBakerPhD
approved these changes
Jun 13, 2024
CodyCBakerPhD
deleted the
fix-complex-validation-while-maintaining-timezone-awareness
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced in #820 where improperly setting the function
thisreference to access the timezone in the generalvalidateOnChangefunction would result in the failure of complex validation steps like the inter-table validation expected on Ecephys tables.Adjusting to always use
JSONSchemaForminstances as thethisvalue, and injecting atimezoneproperty if necessary.Since we're going through changes to our testing utilities, it's worth noting that this would only have been detectable when using the File Metadata page itself, which was why it wasn't flagged in the CI. We'll need to brainstorm ways to catch complex within-page issues like this in the future