Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add units unless property is in the schema #722

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Do not add units unless property is in the schema #722

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a72aad
Do not add units unless property is in the schema
garrettmflynn Apr 3, 2024
bc2a002
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pyflask/manageNeuroconv/manage_neuroconv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,23 +413,24 @@ def get_metadata_schema(source_data: Dict[str, dict], interfaces: dict) -> Dict[
ecephys_properties["Electrodes"] = {"type": "object", "properties": {}, "required": []}

# Populate Units metadata
metadata["Ecephys"]["Units"] = {}
schema["properties"]["Ecephys"]["required"].append("Units")
original_units_schema = ecephys_properties.pop("UnitProperties", None)
metadata["Ecephys"].pop("UnitProperties", None) # Always remove top-level UnitProperties from metadata

has_units = original_units_schema is not None

if has_units:
metadata["Ecephys"]

ecephys_properties["UnitColumns"] = {
"type": "array",
"minItems": 0,
"items": {"$ref": "#/properties/Ecephys/properties/definitions/UnitColumn"},
}

schema["properties"]["Ecephys"]["required"].append("UnitColumns")

ecephys_properties["Units"] = {"type": "object", "properties": {}, "required": []}
metadata["Ecephys"]["Units"] = {}
schema["properties"]["Ecephys"]["required"].append("Units")

def on_sorting_interface(name, sorting_interface):

Expand Down
Loading