Fix Ophys Table Popup #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nv patch for table schema resolution
for more information, see https://pre-commit.ci
|
Do you think any other popups would have been affected or is it pretty specific? |
|
This is the only case where we're using the nested input (rendered as a table here) at the moment, so it's fairly localized. |
|
New error on this PR (this works fine on main minus ability to alter the optical channel stuff) Uncaught (in promise) Error: Request to convert failed: 'name' is a required property
Failed validating 'required' in schema['properties']['Ophys']['properties']['TwoPhotonSeries']:
{'additionalProperties': False,
'properties': {'bits_per_pixel': {'description': 'DEPRECATED: Number '
'of bits per image '
'pixel',
'type': 'number'},
'comments': {'default': 'no comments',
'description': 'Human-readable comments '
'about this TimeSeries '
'dataset',
'type': 'string'},
'control': {'description': 'Numerical labels that '
'apply to each element in '
'data',
'type': 'array'},
'control_description': {'description': 'Description of '
'each control '
'value',
'type': 'array'},
'conversion': {'default': 1.0,
'description': 'Scalar to multiply each '
'element in data to '
'convert it to the '
'specified unit',
'type': 'number'},
'description': {'default': 'no description',
'description': 'Description of this '
'TimeSeries dataset',
'type': 'string'},
'device': {'description': 'Device used to capture the '
'images/video.',
'target': 'pynwb.device.Device',
'type': 'string'},
'dimension': {'description': 'Number of pixels on x, '
'y, (and z) axes.',
'type': 'array'},
'field_of_view': {'description': 'Width, height and '
'depth of image, or '
'imaged area '
'(meters).',
'type': 'array'},
'format': {'description': 'Format of image. Three '
'types - 1) Image format; '
'tiff, png, jpg, etc. 2) '
'external 3) raw.',
'type': 'string'},
'imaging_plane': {'description': 'Imaging plane '
'class/pointer.',
'target': 'pynwb.ophys.ImagingPlane',
'type': 'string'},
'name': {'description': 'The name of this TimeSeries '
'dataset',
'pattern': '^[^/]*$',
'type': 'string'},
'offset': {'default': 0.0,
'description': 'Scalar to add to each '
'element in the data scaled '
"by 'conversion' to finish "
'converting it to the '
'specified unit.',
'type': 'number'},
'pmt_gain': {'description': 'Photomultiplier gain.',
'type': 'number'},
'rate': {'description': 'Sampling rate in Hz',
'type': 'number'},
'resolution': {'default': -1.0,
'description': 'The smallest meaningful '
'difference (in '
'specified unit) between '
'values in data',
'type': 'number'},
'scan_line_rate': {'description': 'Lines imaged per '
'second. This is '
'also stored in '
'/general/optophysiology '
'but is kept here as '
'it is useful '
'information for '
'analysis, and so '
'good to be stored '
'w/ the actual data.',
'type': 'number'},
'starting_frame': {'description': 'Each entry is a '
'frame number that '
'corresponds to the '
'first frame of each '
'file listed in '
'external_file '
'within the full '
'ImageSeries.',
'type': 'array'},
'starting_time': {'description': 'The timestamp of the '
'first sample',
'type': 'number'},
'unit': {'description': 'The unit of measurement of '
'the image data, e.g., values '
'between 0 and 255. Required '
'when data is specified. If '
'unit (and data) are not '
'specified, then unit will be '
'set to "unknown".',
'type': 'string'}},
'required': ['name', 'imaging_plane'],
'tag': 'pynwb.ophys.TwoPhotonSeries',
'type': 'array'}
On instance['Ophys']['TwoPhotonSeries']:
{'comments': 'no comments',
'conversion': 1.0,
'description': 'no description',
'resolution': -1.0}
at run (utils.js:90:33)
at async GuidedMetadataPage.runConversions (Page.js:205:28)
at async GuidedMetadataPage.convert (Page.js:125:27)
at async GuidedFooter.onNext [as __onNext] (GuidedMetadata.js:184:13) |
….com/NeurodataWithoutBorders/nwb-guide into fix-ophys-table-popup-and-validation
for more information, see https://pre-commit.ci
….com/NeurodataWithoutBorders/nwb-guide into fix-ophys-table-popup-and-validation
for more information, see https://pre-commit.ci
CodyCBakerPhD
approved these changes
Apr 3, 2024
CodyCBakerPhD
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Ophys table popup observed in #715
Submitting this without a test at the moment in case we'd like to get it through before today's user test. Otherwise will circle back to this when I've approached the other bugs observed today.