Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip dandi upload #704

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Skip dandi upload #704

merged 8 commits into from
Mar 27, 2024

Conversation

garrettmflynn
Copy link
Member

@garrettmflynn garrettmflynn commented Mar 25, 2024

fix #702

The updated results page if you skip DANDI upload looks like this:
Screenshot 2024-03-25 at 4 56 08 PM

@garrettmflynn garrettmflynn self-assigned this Mar 25, 2024
@CodyCBakerPhD
Copy link
Collaborator

Could you also add the folder file navigator button from the other pages to here? I know it says where they are but still convenient to be able to just press a button to get there

Also just a tad odd that this is listed as being after a greyed out DANDI conversion - could it perhaps be before? (but still only show up if pre-form specified to not upload to DANDI. Kind of tells a story that, 'if they had said they wanted to upload' then 'upload would be the last step'

@garrettmflynn
Copy link
Member Author

Oh sure. This solution allowed me to avoid adding an additional page.

Assuming it'd be alright if the Conversion review page (before DANDI upload) was greyed out during a DANDI workflow?

If so, I'll update the current Conversion review page (after upload) to Upload review.

@CodyCBakerPhD
Copy link
Collaborator

Sure

Also, seems like tests are failing

@garrettmflynn
Copy link
Member Author

Thanks for flagging. I'll tackle this first thing tomorrow

@garrettmflynn
Copy link
Member Author

Gonna render a bit weird on old pipelines since the names and labels were changed. Make sure to test on regenerated test pipelines.

@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn Failing tests

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge March 27, 2024 01:55
@CodyCBakerPhD CodyCBakerPhD merged commit 6da384c into main Mar 27, 2024
14 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the skip-dandi-upload branch March 27, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add page after conversion before upload that says your data has been converted and where
2 participants