-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip dandi upload #704
Skip dandi upload #704
Conversation
for more information, see https://pre-commit.ci
Could you also add the folder file navigator button from the other pages to here? I know it says where they are but still convenient to be able to just press a button to get there Also just a tad odd that this is listed as being after a greyed out DANDI conversion - could it perhaps be before? (but still only show up if pre-form specified to not upload to DANDI. Kind of tells a story that, 'if they had said they wanted to upload' then 'upload would be the last step' |
Oh sure. This solution allowed me to avoid adding an additional page. Assuming it'd be alright if the Conversion review page (before DANDI upload) was greyed out during a DANDI workflow? If so, I'll update the current Conversion review page (after upload) to Upload review. |
Sure Also, seems like tests are failing |
Thanks for flagging. I'll tackle this first thing tomorrow |
Gonna render a bit weird on old pipelines since the names and labels were changed. Make sure to test on regenerated test pipelines. |
@garrettmflynn Failing tests |
fix #702
The updated results page if you skip DANDI upload looks like this: