Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendations from Alessio #697

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Recommendations from Alessio #697

merged 12 commits into from
Apr 3, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

@CodyCBakerPhD CodyCBakerPhD commented Mar 22, 2024

Fix #583

From #583 (comment)

@CodyCBakerPhD CodyCBakerPhD self-assigned this Mar 22, 2024
@CodyCBakerPhD
Copy link
Collaborator Author

@alejoe91 I get

guide\pyflask\manageNeuroconv\manage_neuroconv.py", line 916, in generate_test_data
    artificial_ap_band = artificial_ap_band.scale(gain=1 / conversion_factor_to_uV)
AttributeError: 'InjectTemplatesRecording' object has no attribute 'scale'

Using spikeinterface==0.100.2

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review April 2, 2024 19:46
@CodyCBakerPhD
Copy link
Collaborator Author

OK looks like this is working now

Copy link
Member

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge April 3, 2024 19:19
Copy link
Member

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving for Chromatic run

@CodyCBakerPhD CodyCBakerPhD merged commit 2977e5c into main Apr 3, 2024
14 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the alessio_recommendations branch April 3, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make synthetic data even more realistic
2 participants