-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json encoding to fstring autocompletion #686
Conversation
for more information, see https://pre-commit.ci
Assuming you confirmed that this allows for proper interaction with the test-case defined in the related Issue? |
@garrettmflynn I'm testing it now - it certainly resolves the JSON serialization issue but then triggers other issues - can you give it a look and you probably know better what needs to interact properly Note that for SpikeGLX prior to latest commit I was able to proceed all the way through and it found the data correctly however I could not test that the session start time makes it through to the final stage because the SpikeGLX session time takes precedence over the f-string one So I tried again with a copy of the tutorial data renamed along the lines of |
Updated. Whenever you're encoding into JSON format using a custom encoder, you'll have to reload to an object using |
@garrettmflynn Working great for me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Let's get this through
fix #672