Fix nested input rendering #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
CodyCBakerPhD
approved these changes
Mar 14, 2024
|
Failing test |
CodyCBakerPhD
approved these changes
Mar 15, 2024
|
https://www.chromatic.com/test?appId=640a4d93e34604f275368983&id=65f46c4422d51c1155bdb038 Gap between different fields on a page are much smaller - was that intended? |
|
This change was intended, though the extent of the change shown was not. I don't actually see this when running the GUIDE or the storybook locally |
CodyCBakerPhD
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small rendering issue with the nested JSONSchemaInput properties (e.g.
file_pathsfor the VideoInterface), which convert lists of only one element to single inputs.