Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Persistence following Subject Table Interactions #663

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

garrettmflynn
Copy link
Member

While using the Subject Table with the generate test datasets, it became somewhat annoying to lose the associated source data + metadata results (forever...) when changing the subject name.

To address this, this PR improves the persistence of data when you update the subject table:

  1. Renaming a single subject will result in a persistent link with existing data
  2. Creating a new row and swapping subject_id values and maintaining the same session_id will result in data persistence on the same subject_id
    • Without the same session_id, the data will persist on the new subject_id

I'm open to suggestions regarding further rules, changes to these, and any bugs you notice!

@garrettmflynn garrettmflynn self-assigned this Mar 12, 2024
@garrettmflynn garrettmflynn changed the title Improve subject interaction with results Data Persistence following Subject Table Interactions Mar 12, 2024
@CodyCBakerPhD
Copy link
Collaborator

image

If I change the subject ID of a later row to one of a row above, then delete the row above, I get this (the invalidation is 'subject id already exists')

@garrettmflynn
Copy link
Member Author

Good catch. Thanks!

I've made it so that the table revalidates when any subject_id is resolved from an error state.

@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn Conflict now

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) March 13, 2024 18:55
@CodyCBakerPhD CodyCBakerPhD self-requested a review March 13, 2024 19:11
@CodyCBakerPhD CodyCBakerPhD merged commit 08b957a into main Mar 13, 2024
13 of 16 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the improve-subject-interaction-with-results branch March 13, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants