Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path Expansion Autocomplete Improvements #632

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Conversation

garrettmflynn
Copy link
Member

This PR introduces a set of improvements to the path expansion autocomplete feature as noted by @bendichter after #609 was merged.

These include:

  1. Smaller error messages across the GUIDE
  2. Ability to avoid validation until user input and/or global validation of the form (which only shows requirement-based errors when necessary)
  3. Infer the filesystem path type expected and constrain the selector + title accordingly
  4. Change "Create" to "Submit" on the submission button
  5. Provide the Source Data description (i.e. describe what file to select) when selecting an example file/folder
  6. Re-render the ID inputs when the filesystem path is selected, resulting in updated validation messages

@bendichter
Copy link
Collaborator

looks great!

@CodyCBakerPhD CodyCBakerPhD merged commit 1109009 into main Mar 8, 2024
12 of 15 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the path-expansion-updates branch March 8, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants