Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions #626

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

rly
Copy link
Collaborator

@rly rly commented Feb 27, 2024

  • Replace hyperlink text "NWB-GUIDE-Setup-vX.Y.Z.exe" (and similar) with the correct filename.
  • Add example code to the linux instructions.
  • Change Ubuntu -> Linux. It works on Fedora as well. I think we can generalize to all Linux systems and change this if someone reports it not working on their system.
  • Update Dev instructions to make clear that activating the env is necessary regardless of which OS you use (currently it looks like it applies only to Linux)

@rly rly requested a review from garrettmflynn February 27, 2024 07:58
Copy link
Member

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you!

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) February 27, 2024 18:05
@CodyCBakerPhD CodyCBakerPhD merged commit 374ed89 into main Feb 27, 2024
12 of 15 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the update_install_instructions branch February 27, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants