-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End-to-End Tests + Screenshot capability #582
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…odataWithoutBorders/nwb-guide into tutorial-pipeline-puppeteer
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…odataWithoutBorders/nwb-guide into tutorial-pipeline-puppeteer
for more information, see https://pre-commit.ci
@CodyCBakerPhD Full end-to-end test is completed, including DANDI upload! Just have to tweak a few of the test timeout values so this works across all CI platforms. |
Looks like it works! Let's collect some suggested improvements for these screenshots here then? |
Just checking really quick - that's to staging, right? |
I would say having e2e tests at all is a fantastic thing to have; fine tuning of screenshots can always fall into a follow-up that specifically writes the tutorial BTW, where are the screenshots found? |
Yep! It's to a hardcoded Dandiset that I made on staging. I've started passing my API key as an Action secret to support this behavior. |
Sounds good!
Screenshots are placed in Do you want these to show up in the public repo? |
I say let's decide that in the follow-up focusing on the tutorial specifically; will have to think about upsides/downsides |
Ahh, bummer: chromatic failing here https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/7875721966 |
This PR will use the data generated from #530 to run end-to-end tests using Puppeteer and automatically produce screenshots for a new tutorial on the GUIDE.