Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download inspector report #569

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Download inspector report #569

merged 5 commits into from
Jan 23, 2024

Conversation

garrettmflynn
Copy link
Member

This PR allows users to download the NWB Inspector report as either JSON or text after viewing the initial GUIDE version.

@CodyCBakerPhD
Copy link
Collaborator

This is great!

My one and only qualm is the difference in button text between the pages

Standalone

image

PIpeline

image

@garrettmflynn
Copy link
Member Author

Assuming you'd prefer it all written out? In smaller screen sizes, things can get a bit crowded—but that's fine for the sake of clarity.

@CodyCBakerPhD
Copy link
Collaborator

Assuming you'd prefer it all written out? In smaller screen sizes, things can get a bit crowded—but that's fine for the sake of clarity.

I think both look fine, it's more about having same style for both - so fine to go with shorter version if you prefer

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) January 23, 2024 20:31
@CodyCBakerPhD CodyCBakerPhD merged commit 04864be into main Jan 23, 2024
10 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the download-inspector-report branch January 23, 2024 20:36
@garrettmflynn garrettmflynn mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants