Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Search Dropdown Selection #564

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix Search Dropdown Selection #564

merged 2 commits into from
Jan 17, 2024

Conversation

garrettmflynn
Copy link
Member

This PR fixes the user's ability to select matched elements of the Search list (e.g. global Species metadata on the Subject Metadata page).

Adding an onblur callback on #548 resulted in blocking the usual onclick event since blur events are primary. This is avoided by checking whether the associated target element is one of the list items that the user clicked on, allowing us to skip the onblur callback if this is the case.

@garrettmflynn garrettmflynn self-assigned this Jan 17, 2024
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) January 17, 2024 19:52
@CodyCBakerPhD CodyCBakerPhD merged commit 9826737 into main Jan 17, 2024
10 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix-search-selection branch January 17, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants