Replace Desktop Build Infrastructure with CLI Tool #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it makes more sense, I can also roll back to before the code organization changes (c70390b) so the changelog is simplified. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@garrettmflynn Are we good to close? |
|
Yeah looks like we'll stick with our current solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a CLI tool I've been working on called commoners that would let us build applications like the NWB GUIDE on the same infrastructure without copying code into different repos.
With this PR, files that are not related directly to our frontend or Flask server (e.g. Electron main and preload processes that manage windows and servers) have been removed since their features are now handled by the CLI. While analogous code is still included in the final build, it's worth noting that the final
.dmgfor Mac is nearly half the size of the currentmainbranch build (395 MB vs. 685 MB).As I've been working on this tool on my own time, I've been motivated by how it might help CN and other collaborators produce apps like the GUIDE faster, without the pains we faced when determining the parts of SODA to include or remove.
Using commoners for the GUIDE would be a great test case to run the CLI through its paces—though I also understand it may be out of scope.
Let me know your thoughts!