Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Global Pages #524

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Remove Global Pages #524

merged 3 commits into from
Nov 22, 2023

Conversation

garrettmflynn
Copy link
Member

This PR removes the initial Global Metadata pages in favor of pop-ups on an as-needed basis.

@CodyCBakerPhD
Copy link
Collaborator

Finding a global metadata bug on this PR (unsure if it's technically on main too)

If I fill in multiple fields on the subject metadata table (now my first exposure in the pipeline to the notion of a 'global' value) they do not propagate down to the session level pages

(notably the subject species + age + sex, which is my usual workflow for speeding through the tutorial)

However, they all show back up again if I just go to the 'Global Metadata' specification on the session-level page and hit 'update'

@garrettmflynn
Copy link
Member Author

Great catch. Fixed so that this works even though globalState.project.Subject is not reliably available.

@CodyCBakerPhD CodyCBakerPhD merged commit 40b081c into main Nov 22, 2023
7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the delete-global-pages branch November 22, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants