Use latest dandi dev branch #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettmflynn
approved these changes
Nov 6, 2023
|
Yeah I'll be testing on my Mac here soon too |
for more information, see https://pre-commit.ci
|
@garrettmflynn Do you think we should add a note somewhere on the upload pages that if the user encounters an error with the jobs selector at If so feel free to add that on this PR (I'm not sure of the best way to do so) |
CodyCBakerPhD
commented
Nov 8, 2023
|
@garrettmflynn I can confirm that the v0.11 releases created from this branch both reproduce the issue when jobs is |
CodyCBakerPhD
commented
Nov 8, 2023
|
Just added the note about using a value of On my end, I've had issues building locally (the app fails on open with an error), so trying to figure that out. Might be something funky with my JS environment |
|
Just worked when using v0.0.11 from Github on my Mac (Intel) :) |
CodyCBakerPhD
commented
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thoroughly testing latest distributable on Windows and Mac - I too run into the seg fault error on my Windows device via the distributable (so at least we have a way to test it now...), even after we built in the override
I suspect maybe the older DANDI version is to blame - attempting a rebuild from this branch