Add MiniscopeConverter #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettmflynn
added
the
interface
for more information, see https://pre-commit.ci
garrettmflynn
changed the base branch from
main
to
BrukerTiffMultiPlaneConverter
|
Indeed files look fine, but Inspector message is actually a PyNWB validation error. Also the CLI report shows more info about this issue
The validation error is a known and has been raised upstream for a while. It might actually prevent DANDI upload from within the app, not sure since DANDI uses a slightly different strategy for assessing that aspect |
|
Realized the base of this too late |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the MiniscopeConverter, which currently has an error from the NWB Inspector but can complete a full conversion despite this.