Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate on input delay #476

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Validate on input delay #476

merged 4 commits into from
Oct 30, 2023

Conversation

garrettmflynn
Copy link
Member

@garrettmflynn garrettmflynn commented Oct 26, 2023

This PR allows forms to validate on input delay (currently 1s) instead of waiting for the user to click off the input—as some don't realize to do this.

Alpha Test Issues

  1. Would be nice to be able to get feedback on the validity of your metadata before clicking out of the input but still when you’re done typing (e.g. if the user doesn’t change their input in 2s)

@garrettmflynn garrettmflynn self-assigned this Oct 26, 2023
@CodyCBakerPhD
Copy link
Collaborator

Works fine on the main metadata pages, but does not seem to apply to entering fields to the hands on table - so this is definetely fine as a first step

@CodyCBakerPhD CodyCBakerPhD merged commit 47e225d into main Oct 30, 2023
7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the validate-on-input-delay branch October 30, 2023 19:32
@garrettmflynn
Copy link
Member Author

garrettmflynn commented Oct 30, 2023

Works fine on the main metadata pages, but does not seem to apply to entering fields to the hands on table - so this is definetely fine as a first step

Unfortunately, HOT handles validation internally—and the same way as we were before (i.e. when the user unfocused the element). Since there are many types of cell editors, I haven't been able to find a uniform way to register user inputs for each cell.

As such, forcing HOT validation to occur after a timeout doesn't seem like it's feasible in the short-term—though we may dig deeper in the future and/or implement this feature in our custom table Web Components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants