Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MiniscopeBehaviorInterface #464

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

garrettmflynn
Copy link
Member

This PR adds the MiniscopeBehaviorInterface, which will run a full conversion on the test data.

@garrettmflynn garrettmflynn self-assigned this Oct 17, 2023
@garrettmflynn garrettmflynn added the interface Add support for a specific NeuroConv interface / converter label Oct 17, 2023
@CodyCBakerPhD
Copy link
Collaborator

While the specific error here is due to selecting the incorrect folder path, I had thought we fixed the clipping of the message in Alessios review PR

image

Doesn't need to be fixed here, just wanted to let you know it still happens

@CodyCBakerPhD
Copy link
Collaborator

Also, food for thought - we might want to have a different endpoint for running the inspector on guided mode vs. standalone, and suppress the check about relative video paths in guided mode since user can't change anything about it

Otherwise interface works fine

@CodyCBakerPhD CodyCBakerPhD merged commit a5aac82 into main Oct 17, 2023
6 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the MiniscopeBehaviorInterface branch October 17, 2023 22:50
@garrettmflynn
Copy link
Member Author

While the specific error here is due to selecting the incorrect folder path, I had thought we fixed the clipping of the message in Alessios review PR

Thanks for the heads up! I noticed this as well and pushed a quick fix to main.
Screenshot 2023-10-17 at 4 06 36 PM

This was a persistent issue here because the long file path wasn't wrapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface Add support for a specific NeuroConv interface / converter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants