Add AudioInterface #449
Merged
Add AudioInterface #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
garrettmflynn
added
the
interface
|
Is there a reason to suddenly start exposing the metadata for |
|
No I just didn't make much of it because it didn't fail on the test data. I blocked this on the VideoInterface, I think, so can bring those changes out to a separate PR? |
|
I would suppress the metadata for now Despite how simple it looks there's actually things I'd want to change about it, plus it magnifies the complexity of things to test in this PR |
CodyCBakerPhD
approved these changes
Oct 17, 2023
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the AudioInterface to the GUIDE, which passes on the test data.