Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove app image #443

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Remove app image #443

merged 3 commits into from
Oct 13, 2023

Conversation

CodyCBakerPhD
Copy link
Collaborator

fix #441 and other issues with the linux dist

The dev mode seems to work every time on the linux-fix branch, so just route people there off the bat to avoid frustration with the distributable not working on first try

@CodyCBakerPhD CodyCBakerPhD self-assigned this Oct 13, 2023
garrettmflynn
garrettmflynn approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. At present, there are a significant number of (seemingly) unavoidable headaches with the Linux distribution.

If we ever want to test the distribution again, we can always simply reproduce the workflow file and try again.

@CodyCBakerPhD CodyCBakerPhD merged commit ecad9ae into main Oct 13, 2023
6 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the remove_app_image branch October 13, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmflynn garrettmflynn garrettmflynn approved these changes

Assignees

@CodyCBakerPhD CodyCBakerPhD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] GLIBC_2.33 not found, from the release NWB-GUIDE-0.0.10.AppImage
2 participants
@CodyCBakerPhD @garrettmflynn