Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TDT Support #246

Merged
merged 8 commits into from
Jan 29, 2024
Merged

Add TDT Support #246

merged 8 commits into from
Jan 29, 2024

Conversation

garrettmflynn
Copy link
Member

This PR adds support for the TdtRecordingInterface to the GUIDE.

@garrettmflynn garrettmflynn self-assigned this Jul 12, 2023
Base automatically changed from biocam to neuroscope-sorting July 14, 2023 17:56
Base automatically changed from neuroscope-sorting to main August 4, 2023 04:45
@CodyCBakerPhD CodyCBakerPhD marked this pull request as draft August 8, 2023 19:56
@CodyCBakerPhD
Copy link
Collaborator

Going to convert this to draft until NeuroConv directly exposes gain (should be renamed to conversion_factor in NeuroScope too probably): catalystneuro/neuroconv#540

Would need to dig a bit deeper but it appears this format might not automatically record the conversion factor, meaning the data being converted here is potentially wrong, which is misleading.

If using NeuroConv directly the user would have been expected to set the gain manually after initializing the interface so not quite a bit of an issue there; but here the user has no control exposed

Base automatically changed from accidental_push_to_main to main August 19, 2023 00:25
@garrettmflynn garrettmflynn added the interface Add support for a specific NeuroConv interface / converter label Sep 28, 2023
@CodyCBakerPhD
Copy link
Collaborator

This was recently fixed on the NeuroConv side (gain was explicitly exposed)

However, a bizarre issue on the front end side (not altogether blocking, will probably raise as separate issue)

If I type 0 - . - any other number, such as a common gain of 0.195, the form entry bugs out and the . moves the insertion line to the left and does not add the . character

To insert the correct value, I need to start with the . instead

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review January 29, 2024 20:32
@CodyCBakerPhD CodyCBakerPhD merged commit 0d80875 into main Jan 29, 2024
10 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the tdt branch January 29, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface Add support for a specific NeuroConv interface / converter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants