Merge pull request #484 from NeurodataWithoutBorders/fix-subject-table

Allow editing sessions on new rows
NeurodataWithoutBorders · Oct 31, 2023 · 8161005 · 8161005
2 parents 11b6fc8 + 586bd7c
commit 8161005
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/renderer/src/stories/Table.js b/src/renderer/src/stories/Table.js
@@ -116,12 +116,8 @@ export class Table extends LitElement {
             if (col === this.keyColumn) {
                 if (hasRow) value = row;
                 else return undefined;
-            } else
-                value =
-                    (hasRow ? this.data[row][col] : undefined) ??
-                    this.template[col] ??
-                    // this.schema.properties[col].default ??
-                    "";
+            } else value = (hasRow ? this.data[row][col] : undefined) ?? this.template[col];
+
             return value;
         });
     }

diff --git a/src/renderer/src/stories/hot.js b/src/renderer/src/stories/hot.js
@@ -86,12 +86,13 @@ class ArrayEditor extends Handsontable.editors.TextEditor {
                 .split(",")
                 .map((str) => str.trim())
                 .filter((str) => str);
+
             return this.cellProperties.uniqueItems ? Array.from(new Set(split)) : split; // Only unique values
         }
     }
 
     setValue(newValue) {
-        if (Array.isArray(newValue)) return newValue.join(",");
+        if (Array.isArray(newValue)) newValue = newValue.join(",");
         super.setValue(newValue);
     }
 }