Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convertTrials tutorial (#515) #594

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Sep 14, 2024

Fix #515

Motivation

Fix outdated tutorial

How to test the behavior?

Run tutorial

The tutorial should run without errors and the exported file can be read with matnwb and pynwb v2.8.1

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.63%. Comparing base (1b7b657) to head (c81a78b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
+ Coverage   90.60%   90.63%   +0.03%     
==========================================
  Files         106      106              
  Lines        4671     4687      +16     
==========================================
+ Hits         4232     4248      +16     
  Misses        439      439              
Flag Coverage Δ
90.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter bendichter merged commit c4bb19c into master Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: convertTrials Tutorial uses Out of Date Syntax
2 participants