Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getRow function for dynamic table if row data is an array where ndims is 3 or higher #590

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Sep 12, 2024

Fix #576

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

Show here how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@ehennestad ehennestad marked this pull request as ready for review September 12, 2024 10:45
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.57%. Comparing base (fd34d3d) to head (fc46950).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
+types/+util/+dynamictable/getRow.m 66.66% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
- Coverage   90.71%   90.57%   -0.15%     
==========================================
  Files         105      105              
  Lines        4632     4657      +25     
==========================================
+ Hits         4202     4218      +16     
- Misses        430      439       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter bendichter merged commit 4b280cb into master Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: toTable method does not work on PlaneSegmentation objects
2 participants