Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly ignore files for coverage #553

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

lawrence-mbf
Copy link
Collaborator

@lawrence-mbf lawrence-mbf commented Dec 15, 2023

Motivation

Some files are erroneously being checked for coverage due to a bug in the nwbtest.m script. This PR fixes the script and adds the +test module to the ignoreFolders argument.

How to test the behavior?

the coverage should ignore +tests directory and +misc/generateDocs.m

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@lawrence-mbf lawrence-mbf self-assigned this Dec 15, 2023
@lawrence-mbf lawrence-mbf marked this pull request as ready for review December 15, 2023 15:15
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3267d8d) 87.96% compared to head (d21ddea) 87.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage   87.96%   87.11%   -0.86%     
==========================================
  Files         133      104      -29     
  Lines        5677     4617    -1060     
==========================================
- Hits         4994     4022     -972     
+ Misses        683      595      -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lawrence-mbf lawrence-mbf merged commit 753bd63 into master Dec 15, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant