Add Filtered Ephys Reference #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When empty, the Dynamic Table probably does not have an id initialized. This is normally populated in `checkConfig` so it should be done before DataStub ID checks.
If checkConfig fails for DynamicTable when the real vector heights do not match, a different error may be thrown as it assumes that all data objects have a length function. This is not true for DataStub objects so this message would never be shown to the user.
For char arrays, there is really only one representation that distinguishes between plural row and not and this is fundamentally different from our flipped matrix representation for numeric types.
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
==========================================
+ Coverage 87.77% 87.78% +0.01%
==========================================
Files 132 132
Lines 5621 5626 +5
==========================================
+ Hits 4934 4939 +5
Misses 687 687
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #532
Motivation
Match listed FilteredEphys reference in PyNWB documentation
How to test the behavior?
Check HTML ecephys.html tutorial
Checklist
fix #XXwhereXXis the issue number?