Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Component Order #530

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Check Component Order #530

merged 7 commits into from
Jul 28, 2023

Conversation

lawrence-mbf
Copy link
Collaborator

Motivation

Fixes #526

How to test the behavior?

  1. Create a TimeSeries
  2. Reference the TimeSeries in one row of TimeIntervals timeseries
  3. export the file and run nwbinspector

There should not be a weird indexing-related hdmf error.
Ideally, MATLAB show throw the error before the file is written.

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

Note that the attributes are still created (as they should be) but
writing empty data to them causes errors in HDF5.
Very important before writing to dataset
- expand and clarify variable names
- Add order and field existence checks to compound data types
- convert empty types to their expected values if possible.
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #530 (bbf83ef) into master (d8c7d71) will increase coverage by 0.03%.
The diff coverage is 91.40%.

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage   87.67%   87.71%   +0.03%     
==========================================
  Files         132      132              
  Lines        5550     5584      +34     
==========================================
+ Hits         4866     4898      +32     
- Misses        684      686       +2     
Files Changed Coverage Δ
+io/mapData2H5.m 95.74% <66.66%> (-2.04%) ⬇️
+file/mapType.m 94.28% <84.61%> (ø)
+types/+util/checkDtype.m 86.66% <89.33%> (+3.33%) ⬆️
+file/fillConstructor.m 96.35% <100.00%> (+0.02%) ⬆️
+file/fillExport.m 98.72% <100.00%> (+0.01%) ⬆️
+io/writeAttribute.m 85.00% <100.00%> (+0.78%) ⬆️
NwbFile.m 82.85% <100.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lawrence-mbf lawrence-mbf marked this pull request as ready for review July 28, 2023 20:34
@lawrence-mbf lawrence-mbf merged commit 286d6b5 into master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Compound Typechecks should Enforce Order
1 participant