Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly Convert References in Compound Datasets #529

Merged
merged 8 commits into from
Jul 28, 2023

Conversation

lawrence-mbf
Copy link
Collaborator

Fixes #528

Motivation

Normal references appear to work but references embedded in compound datasets do not which causes errors on reshaping the data.

How to test the behavior?

See #528

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

- retab function
- function no longer returns table due to ambiguous implications from
  vector direction.
- expand variable names and remove useless functions
- Retab function
- expand variable and loop names
Also support reference types nested in compound structs
@lawrence-mbf lawrence-mbf self-assigned this Jul 28, 2023
Since we allow multiple types of inputs for compound data types we need
to allow for multiple output validation for them too.
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #529 (68924c2) into master (b7583a3) will increase coverage by 0.06%.
The diff coverage is 92.79%.

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
+ Coverage   87.61%   87.67%   +0.06%     
==========================================
  Files         130      132       +2     
  Lines        5537     5550      +13     
==========================================
+ Hits         4851     4866      +15     
+ Misses        686      684       -2     
Files Changed Coverage Δ
+io/parseCompound.m 73.52% <73.52%> (-3.40%) ⬇️
+io/parseReference.m 86.11% <86.11%> (+0.81%) ⬆️
+types/+untyped/@DataStub/export.m 94.11% <94.11%> (ø)
+types/+untyped/@DataStub/DataStub.m 95.50% <95.50%> (ø)
+types/+untyped/@DataStub/load_mat_style.m 95.74% <95.74%> (ø)
+tests/+util/verifyContainerEqual.m 98.24% <98.24%> (-1.76%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lawrence-mbf lawrence-mbf marked this pull request as ready for review July 28, 2023 17:21
@lawrence-mbf lawrence-mbf merged commit d8c7d71 into master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error when Loading Compound data with Object References from a Datastub
1 participant