Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra generated checks for attributes #518

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

lawrence-mbf
Copy link
Collaborator

Fixes #498

Motivation

See #498

How to test the behavior?

#498 (comment)

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

If the attribute is dependent on another property, then the dependent
object should be treated as empty if the object is a link.
@lawrence-mbf lawrence-mbf marked this pull request as ready for review July 24, 2023 19:37
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #518 (ff43b5c) into master (12f1996) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   87.87%   87.87%           
=======================================
  Files         129      129           
  Lines        5458     5461    +3     
=======================================
+ Hits         4796     4799    +3     
  Misses        662      662           
Files Changed Coverage Δ
+file/fillExport.m 98.70% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lawrence-mbf lawrence-mbf merged commit d97e670 into master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect Behavior Attribute Write when Dataset/Group is replaced with a Link
1 participant