Add explicit checks to DataStub indices #514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #513
Motivation
The original code probably assumed that the low-level HDF5 calls would check for valid inputs and spaces. This appears not to be the case for the following two cases:
DataStub
, it repeats the values of the first (valid) index instead.DataStub
returns an empty cell array.How to test the behavior?
This example script sets up a condition where issue (1) occurs
As mentioned in the code snippet, (2) is currently not reproducible. However, this PR should resolve both potential index errors anyway.
Checklist
fix #XX
whereXX
is the issue number?