Cast empty array to correct type before adding row #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
==========================================
- Coverage 87.56% 87.25% -0.31%
==========================================
Files 128 128
Lines 5348 5250 -98
==========================================
- Hits 4683 4581 -102
- Misses 665 669 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
When concatenating to an empty double array "[]", MATLAB usually "adopts" the type from the new element instead of attempting to cast to the double type. As it turns out, logical values are a rare type where concatenating a "false" or "true" to an empty array actually returns the double value of the empty array type. This added check fixes this specific case.
- Blueprint datapipes now support the same load() and append() calls one could use with Bound datapipes. These simply operate with the data cached in memory. - Added a few fixes and special cases that Dynamic Tables did not actually check for. - Support tables when getting row
lawrence-mbf
force-pushed
the
458-prevent-type-erasure-on-add-row
branch
from
01ab16f to
fad8cb3
Compare
vectorindex references where needed.
blueprint pipe vector dimensions are not necessarily aligned with its axis dimension. This is intentional as the axis dimension reflects the data dimension when written to disk (to fit with how it works with the bound pipe).
MatNWB -> NWB since errors thrown in MATLAB make this a redundant specifier as a domain.
This was referenced Nov 15, 2022
Merged
bendichter
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #458
How to test the behavior?
See #458
Checklist
fix #XXwhereXXis the issue number?