remove positive number validation for getRow ind. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-mbf
requested changes
Sep 29, 2021
There was a problem hiding this comment.
Since ind isn't used until useId is checked for on line 29, I would like to still check that the index is within a valid range if useId is not set. Something like:
if p.Results.useId
validateattributes(ind, {'numeric'}, {'vector'});
ind = getIndById(DynamicTable, ind);
else
validateattributes(ind, {'numeric'}, {'positive', 'vector'});
end
|
@ln-vidrio that sounds fine |
moves the index validation to after the "useIds" flag is validated. Allow numeric ids that are not necessarily positive as ids can be arbitrary.
If useID is True, then ind can be of value 0
lawrence-mbf
force-pushed
the
fix-310-get_row_by_id
branch
from
b95f7f2 to
3a99b91
Compare
|
pipeline failure allowable as that should be resolved by #575 |
lawrence-mbf
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #310, #573
If useID is True, then ind can be of value 0