Schema 2.3.0 #278
Merged
Schema 2.3.0 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
May 12, 2021 15:55
Due to how VectorIndex is now a VectorData subtype, we now store everything under the `vectordata` property in DynamicTable. All references to the legacy `vectorindex` has been replaced.
remove reference to `vectorindex` property as that no longer exists.
- Given how the MATLAB table already requires data splitting according to data type, adding a row by tableRow no longer requires wrapping a cell. - The mere existence of `tablepath` now forces the creation of a Ragged Array regardless of whether or not the data fits to the standard.
VectorIndex used to subclass the Index type which did not require it to have a `description` property. It now automatically sets it to prevent export errors.
- addRawData: reorganize redundant logic. - checkDtype. Add error ID and reformat error message.
Due to quirks in the generation functions, DynamicTable utilities may occur in vectordata OR vectorindex going forward. All pre-2.3.0 Dynamic Tables only store their VectorIndex objects into `vectorindex` while post-2.3.0 VectorIndex objects are stored in `vectordata` along with VectorData.
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 47.82% 47.65% -0.18%
==========================================
Files 124 124
Lines 5599 5634 +35
==========================================
+ Hits 2678 2685 +7
- Misses 2921 2949 +28
Continue to review full report at Codecov.
|
added 6 commits
May 27, 2021 14:17
- Actually treat the expected type as a minimum as is true in nwb-schema. If the value type is larger than the expected type, then scale progressively to fit. - Fix dynamic table indexing due to VectorIndex now being set to uint8 as an expected type. The type should start at uint8 but scale upwards as the indices get larger.
- Fix logic error regarding intervals timeseries storage. - Fix missing descriptor for the VectorIndex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update NWB Schema to 2.3.0