Fix/findshapes slow #270
Merged
Fix/findshapes slow #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2021 12:37
Original findShapes behavior involved three nested loops slowly iterating each start/stop/step pointer which had the very real possibility of hanging on large index sizes. New method fixes this issue by trimming and subdividing disjoint block selections.
Originally just selected the first possible segment which isn't optimal. Now selects the largest selection first.
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 47.46% 47.47% +0.01%
==========================================
Files 124 124
Lines 5592 5594 +2
==========================================
+ Hits 2654 2656 +2
Misses 2938 2938
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Datastub findShapes algorithm does not scale well at all and can potentially cause serious hangs. This PR greatly reduces the time taken to find the proper selection shapes.