-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HDF5IO tests for add_read PR #118
base: add_read
Are you sure you want to change the base?
Conversation
@stephprince there is still an issue with reading strings, but otherwise this PR is ready for you to take a look at. |
I have confirmed now that the fixed length string dataset is being written correctly. However, reading of fixed length string data still fails. I have not investigated the issues with variable length strings yet. |
Ok, fixed length strings seem to work now for both write and read. Next up, variable length strings. |
@stephprince I've now fixed the writing/reading of fixed and variable length strings. This PR is ready for you to take a look at. I think the other TODO items for #85 are probably best done in additional PRs, otherwise this PR will become to large. The last remaining issue for this PR is to fix the address sanitizer test. It looks like the sanitizer doesn't like something about the changes in |
This PR targets #85 to complete open ToDo items to add unit tests.
Add unit tests for public
HDF5IO
-specific functions (i.e., not inherited fromBaseIO
)HDF5IO::getH5ObjectType
HDF5IO::getNativeType
HDF5IO::getH5Type
Add unit tests for new public
HDF5IO
functions (which are core functions new inBaseIO
). While some of these are partially covered by theDEFINE_FIELDS
read tests, it will be useful to more fully test these separatelyHDF5IO::readDataset
(incl. with start, count, stride, and block parameters set). This is to test that reading subsets of larger arrays works as expected.HDF5IO::open(FileMode mode)
test that file modes are being set correctlyHDF5IO::readAttribute
HDF5IO::getStorageObjectType
HDF5IO::getGroupObjects
HDF5IO::attributeExists
HDF5IO::objectExists
New TODO items identified in unit tests:
HDF5IO::readDataset
to cover all numeric types inBaseDataType
TEST_CASE("HDF5IO; read dataset", "[hdf5io]")
andTEST_CASE("HDF5IO; read dataset subset", "[hdf5io]")
.HDF5RecordingData::writeDataBlock