Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add developer documentation note on merge commits for PRs #113

Closed
stephprince opened this issue Dec 19, 2024 · 0 comments · Fixed by #136
Closed

Add developer documentation note on merge commits for PRs #113

stephprince opened this issue Dec 19, 2024 · 0 comments · Fixed by #136
Assignees
@oruebel
Labels
priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation

Comments

@stephprince
Copy link
Collaborator

Add note in developer test docs to clarify that tests on PR's are running on a temporary merge commit to test that the PR functions correctly when merged with the target branch (see #85 (comment))
@oruebel oruebel mentioned this issue Dec 20, 2024
Merged
49 tasks
@stephprince stephprince added priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation labels Jan 14, 2025
oruebel added a commit that referenced this issue Jan 14, 2025
@oruebel
Fix #113 add note in the docs about GitHub actions running on a merge…
cfd219a 
… commit
oruebel added a commit that referenced this issue Jan 14, 2025
@oruebel
Fix #113 add note in the docs about GitHub actions running on a merge…
ad3024a 
… commit
@oruebel oruebel mentioned this issue Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oruebel oruebel

Labels
priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add note about CI using temporary merge commits to the docs NeurodataWithoutBorders/aqnwb
2 participants
@oruebel @stephprince